Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mark master nodes as schedulable #1077

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: mark master nodes as schedulable #1077

merged 1 commit into from
Mar 14, 2024

Conversation

psturc
Copy link
Member

@psturc psturc commented Mar 14, 2024 •
edited
Loading

Description

this PR add a pre-installation command for patching cluster scheduler in order to mark master nodes as schedulable

Issue ticket number and link

KFLUXBUGS-1154

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

make local/cluster/prepare
Screenshot 2024-03-14 at 9 45 31

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc psturc mentioned this pull request Mar 14, 2024
Merged
@kasemAlem
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit aba7388 into konflux-ci:main Mar 14, 2024
15 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Mar 14, 2024
Closed
@psturc psturc deleted the KFLUXBUGS-1154 branch April 3, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasemAlem kasemAlem kasemAlem approved these changes

@Josh-Everett Josh-Everett Awaiting requested review from Josh-Everett

@sonam1412 sonam1412 Awaiting requested review from sonam1412

Assignees

@kasemAlem kasemAlem

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psturc @kasemAlem